Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40722 )
Change subject: [WIP] Add Multiple Segment support ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40722/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/systemagent.h:
https://review.coreboot.org/c/coreboot/+/40722/3/src/soc/intel/common/block/... PS3, Line 13: x
Maybe give this a name for clarity, e.g. `segments`. […]
Ack
https://review.coreboot.org/c/coreboot/+/40722/3/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/40722/3/src/soc/intel/common/block/... PS3, Line 12: config SA_PCI_SEGMENT_GROUPS
This is not Intel specific, IMO it belongs into src/device/Kconfig. Without […]
Ack
https://review.coreboot.org/c/coreboot/+/40722/3/src/soc/intel/common/block/... PS3, Line 13: hex
Can be `int`.
Ack