Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38475 )
Change subject: mainboard/hatch: Fix puff display on cold boots ......................................................................
Patch Set 2:
(4 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... PS2, Line 33: gpio_input(gpio); This would be unnecessary with the suggestion below.
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... PS2, Line 42: mdelay(200);
200 ms seems too long for fast boot experience, doesn’t it? 10 ms or 20 ms?
From testing, this tends to complete after 800-1200ms.
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... PS2, Line 54: gpio_input(GPIO_HDMI_HPD); gpio_input(GPIO_DP_HPD);
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... PS2, Line 55: ) && !gpio_get(GPIO_DP_HPD)