[coreboot-gerrit] Change in coreboot[master]: mb/prodrive/hermes: Use PCH_DEV_SMBUS definition

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47959 )

Change subject: mb/prodrive/hermes: Use PCH_DEV_SMBUS definition
......................................................................

mb/prodrive/hermes: Use PCH_DEV_SMBUS definition

This allows dropping ugly preprocessor usage from this file.

Change-Id: Idb66d295129d98725f38d11ac162978418bd94c2
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47959
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M src/mainboard/prodrive/hermes/eeprom.c
1 file changed, 3 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c
index 94811f6..fee40a0 100644
--- a/src/mainboard/prodrive/hermes/eeprom.c
+++ b/src/mainboard/prodrive/hermes/eeprom.c
@@ -31,14 +31,8 @@
 {
    int ret = 0;

-#if ENV_ROMSTAGE
-	pci_devfn_t dev = PCI_DEV(0, PCH_DEV_SLOT_LPC, 4);
-#else
-	const struct device *dev = pcidev_on_root(PCH_DEV_SLOT_LPC, 4);
-#endif
-
-	u32 smb_ctrl_reg = pci_read_config32(dev, HOSTC);
-	pci_write_config32(dev, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);
+	u32 smb_ctrl_reg = pci_read_config32(PCH_DEV_SMBUS, HOSTC);
+	pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);

printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__,
    	read_offset, size);
@@ -61,7 +55,7 @@
    }

/* Restore I2C_EN bit */
-	pci_write_config32(dev, HOSTC, smb_ctrl_reg);
+	pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg);

return ret;
 }