Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40485 )
Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG@11 PS1, Line 11: 1866 MHz frequency (= 2*933). `1866 MT/s` is the same as `933 MHz`, so this part should be:
1866 MT/s (933 MHz)
https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG@13 PS1, Line 13: MHz MT/s
https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c:
https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... PS1, Line 73: GfxMemClockFrequencyDefinitionTable How about adding a check to whatever uses this array? If the value is zero, bail out instead of dividing by zero. (please create a separate commit to fix this, though)