Attention is currently required from: Arthur Heymans, Furquan Shaikh, Subrata Banik, Johnny Lin, Ed Sharma, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66819 )
Change subject: Recently published Intel CedarIslandFSP binary contains PE images in FSP-M and FSP-S. This causes coreboot boot hang on DeltaLake servers.
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158189):
https://review.coreboot.org/c/coreboot/+/66819/comment/4c1577db_f2e77d18
PS2, Line 6:
Possible long commit subject (prefer a maximum 65 characters)
File src/commonlib/fsp_relocate.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158189):
https://review.coreboot.org/c/coreboot/+/66819/comment/e1051fad_9e5e2e86
PS2, Line 223: roffset = read_le32(&ophdr->DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_BASERELOC].VirtualAddress);
line length of 103 exceeds 96 columns
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66819
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e
Gerrit-Change-Number: 66819
Gerrit-PatchSet: 2
Gerrit-Owner: Ed Sharma
aeddiesharma@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ed Sharma
aeddiesharma@fb.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Comment-Date: Wed, 07 Sep 2022 01:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment