Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30936 )
Change subject: mainboard/hp: Add HP Elitebook 8760w as a variant of 8460p ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/30936/1/src/mainboard/hp/8460p/Kconfig File src/mainboard/hp/8460p/Kconfig:
https://review.coreboot.org/#/c/30936/1/src/mainboard/hp/8460p/Kconfig@24 PS1, Line 24: BOARD_HP_8760W
if BOARD_HP_8460P […]
Done
https://review.coreboot.org/#/c/30936/1/src/mainboard/hp/8460p/variants/8760... File src/mainboard/hp/8460p/variants/8760w/devicetree.cb:
https://review.coreboot.org/#/c/30936/1/src/mainboard/hp/8460p/variants/8760... PS1, Line 34: :
Please add this here and remove the other subsystemid entries: […]
Done
https://review.coreboot.org/#/c/30936/1/src/mainboard/hp/8460p/variants/8760... PS1, Line 42: end
Please move to the previous line.
Done