Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37730 )
Change subject: util/autoport: correct build errors of produced files ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/azalia.go File util/autoport/azalia.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/azalia.go@a55 PS2, Line 55: Audio controller
It results in "High Definition Audio Audio Controller"
Ack
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go File util/autoport/bd82x6x.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go@a2... PS2, Line 279: PCI-
It is kind of redundant, results in "LPC bridge PCI-LPC bridge". I might as well drop it altogether.
Well, if I take `PCI-` out of `LPC bridge PCI-LPC bridge` what will be left is `LPC bridge LPC bridge`?
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/main.go File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/main.go@821 PS2, Line 821: fmt.Fprintf(bi, "Flashrom support: %s\n", FlashROMSupport)
It's easier to complete the fields that way. […]
Just put it in the commit message, please.
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/sandybridge.g... File util/autoport/sandybridge.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/sandybridge.g... PS2, Line 137: RegisterPCI(0x8086, id, GenericVGA{GenericPCI{Comment: "VGA controller"}})
Results in "Integrated Graphics VGA Controller", which is rather obnoxious.
Ack