View Change

4 comments:

• File util/autoport/azalia.go:

  • Patch Set #2, Line 55: Audio controller

    It results in "High Definition Audio Audio Controller"

    Ack

• File util/autoport/bd82x6x.go:

  • Patch Set #2, Line 279: PCI-

    It is kind of redundant, results in "LPC bridge PCI-LPC bridge". I might as well drop it altogether.

    Well, if I take `PCI-` out of `LPC bridge PCI-LPC bridge` what will be left
    is `LPC bridge LPC bridge`?

• File util/autoport/main.go:

  • Patch Set #2, Line 821: fmt.Fprintf(bi, "Flashrom support: %s\n", FlashROMSupport)

    It's easier to complete the fields that way. […]

    Just put it in the commit message, please.

• File util/autoport/sandybridge.go:

  • Patch Set #2, Line 137: RegisterPCI(0x8086, id, GenericVGA{GenericPCI{Comment: "VGA controller"}})

    Results in "Integrated Graphics VGA Controller", which is rather obnoxious.

    Ack

To view, visit change 37730. To unsubscribe, or for help writing mail filters, visit settings.