Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39299 )
Change subject: mb/asus/p8z77-v_lx2: Add new mainboard ......................................................................
Patch Set 3: Code-Review+1
(7 comments)
Nice job!
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG@7 PS3, Line 7: mb/asus/p8z77-v_lx2: Add new mainboard Add Sandy Bridge mainboard
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG@27 PS3, Line 27: Add tested payload and OS?
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 18: */ Use official comment styles?
https://doc.coreboot.org/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 20: Method(_PTS,1) Add space before the comma?
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 26: Method(_WAK,1) Ditot.
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/early_init.c:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 48: /* Select SIO pin states. */ Remove the dot/period at the end?
Are these from the datasheet or superiotool dump?
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 57: /* Power RAM in S3. */ Remove dot/period at end.