Attention is currently required from: Tarun Tuli, Subrata Banik, Patrick Rudolph, Paul Menzel, Arthur Heymans.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Patrick Rudolph, Paul Menzel, Maximilian Brune, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64625
to look at the new patch set (#31).
Change subject: cpu/x86/mp_init.c: Generate a C header to get start32 offset ......................................................................
cpu/x86/mp_init.c: Generate a C header to get start32 offset
In the current design the relocatable parameters are used to know the offset of the 32bit startpoint. This requires back and forward interaction between the stub, the loader and the mp init code. This makes the code hard to read.
This is static information known at buildtime, so a better way to deal with this is to generate a header that contains this offset.
Change-Id: Ic01badd2af11a6e1dbc27c8e928916fedf104b5b Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/Makefile.inc M src/cpu/x86/mp_init.c M src/cpu/x86/smm/smm_module_loader.c M src/cpu/x86/smm/smm_stub.S A src/cpu/x86/smm_start32_offset.h.template M src/include/cpu/x86/smm.h 6 files changed, 45 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/64625/31