Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38155 )
Change subject: soc/intel/{cnl,icl,tgl}: Move northbridge.asl into common/block/acpi
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
A build test with `BUILD_TIMELESS` might be a good test.
https://review.coreboot.org/c/coreboot/+/38155/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38155/2//COMMIT_MSG@10
PS2, Line 10: ask
ask*s*
*changes* might be better though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9af844bcbbcce3f4b0ac7aada43d43e4171e08b
Gerrit-Change-Number: 38155
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 Jan 2020 12:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment