Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33016 )
Change subject: src/driver/vpd: Check decoded content length before invoking callback
......................................................................
Patch Set 2:
Actually, I think we should make these changes in platform/vpd
I do have same fix in platform/vpd under review.
But yes, we've seen similar comments there for why it's int instead of uint.
I'll finish platform/vpd review first and then upstream here.
Alternatively, we could consider relocating platform/vpd into platform/vboot_reference
Probably no. vboot is nothing related (and should not) to vpd.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3928e9c43cb87caf93fb44ee10434ce80f0a188a
Gerrit-Change-Number: 33016
Gerrit-PatchSet: 2
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 27 May 2019 07:37:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment