Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42970 )
Change subject: soc/amd/picasso: Add support for generating I2S machine device ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42970/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42970/1//COMMIT_MSG@10 PS1, Line 10: device(AMDI5682) Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c File src/soc/amd/picasso/acp.c:
https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c@8... PS1, Line 86: 0);/* Active low = 0 (Kernel driver does not use active polarity). */ Please add a space in `;/*`.