Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48485 )
Change subject: soc/amd/picasso/aoac: only check FCH_AOAC_UART_FOR_CONSOLE if used
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c
File src/soc/amd/picasso/aoac.c:
https://review.coreboot.org/c/coreboot/+/48485/4/src/soc/amd/picasso/aoac.c@...
PS4, Line 43: aoac_devs
Some day we should make this smarter. We can probably save a little power by not enabling devices a board doesn't use.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I103dd8d469a084c7dc7dcf55175b1f77f900adc5
Gerrit-Change-Number: 48485
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 00:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment