[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/variants/eldrid: Configure DP_HPD as PAD_NC and dis...

[Nick Chen (Code Review)]

Nick Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45246 )

Change subject: mb/google/volteer/variants/eldrid: Configure DP_HPD as PAD_NC and disable DdiPortHpd
......................................................................

mb/google/volteer/variants/eldrid: Configure DP_HPD as PAD_NC and disable
DdiPortHpd

GPP_A19(DP_HPD1) and GPP_A20(DP_HPD2) were configured native function
(NF1) without internal pull-down which wrongly presents HPD interrupts.
This change configures GPP_A19 and GPP_A20 to be no connection and
disables DdiPort1Hpd and DdiPort2Hpd.

BUG=b:165893624, b:168090618

Signed-off-by: nick_xr_chen 
Change-Id: I31b25be1c9248debf855435c7b688b358e2cd57e
---
M src/mainboard/google/volteer/variants/eldrid/gpio.c
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
2 files changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45246/1

diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c
index aeccfab..855e96d 100644
--- a/src/mainboard/google/volteer/variants/eldrid/gpio.c
+++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c
@@ -19,9 +19,9 @@
    /* A16 : USB_OC3# ==> USB_C0_OC_ODL */
    PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1),
    /* A19 : DDSP_HPD1 ==> USB_C0_DP_HPD */
-	PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1),
+	PAD_NC(GPP_A19, NONE),
    /* A20 : DDSP_HPD2 ==> USB_C1_DP_HPD */
-	PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1),
+	PAD_NC(GPP_A20, NONE),
    /* A21 : DDPC_CTRCLK ==> EN_FP_PWR */
    PAD_CFG_GPO(GPP_A21, 1, DEEP),
    /* A23 : I2S1_SCLK ==> I2S1_SPKR_SCLK */
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index 171e397..b04b1e7 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -1,6 +1,8 @@
 chip soc/intel/tigerlake

register "TcssAuxOri" = "1"
+	register "DdiPort1Hpd" = "0"
+	register "DdiPort2Hpd" = "0"
    register "IomTypeCPortPadCfg[0]" = "0x090E000A"
    register "IomTypeCPortPadCfg[1]" = "0x090E000D"
    #+-------------------+---------------------------+