Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47746?usp=email )
Change subject: nb/intel/sandybridge: Refine power-down mode logic
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47746/comment/30db0cb5_8d5ef080 :
PS5, Line 11: Do not use APD with DLL-off on mobile:
: vendor firmware does not use it, and it can influence system stability.
mrc.bin does in fact use this mode on mobile...
on x220 to be specific. This might be causing stability problems: https://ticket.coreboot.org/issues/121
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47746?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8e98162ca86ae454a8c951be163d58960940e0e
Gerrit-Change-Number: 47746
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 04 Jan 2024 07:58:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment