Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45320 )
Change subject: soc/intel/common/block: Use pci_dev_request_bus_master for BM enabling ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Looks good to me, but I'd like to make sure we all know what the purpose of `pci_dev_request_bus_master` is.
https://review.coreboot.org/c/coreboot/+/45320/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45320/1//COMMIT_MSG@9 PS1, Line 9: Replace static sata_final() implementation for BM enabling with generic : pci_dev_request_bus_master() function. The purpose of `pci_dev_request_bus_master` is to have a single switch to disable unnecessary bus master enabling. I'd expand this to explain the purpose of this change:
Enabling Bus Master isn't required by the hardware, so we shouldn't need to enable it at all. However, some payloads do not set this bit before attempting DMA transfers, which results in boot failures.
Replace static sata_final() implementation for BM enabling with generic pci_dev_request_bus_master() function. This allows the user to control through Kconfig whether Bus Master should be enabled.
https://review.coreboot.org/c/coreboot/+/45320/1//COMMIT_MSG@12 PS1, Line 12: sata nit: SATA