Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40764 )
Change subject: src/cpu/x86/mtrr/earlymtrr: Add clear_all_var_mtrr ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40764/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40764/1//COMMIT_MSG@9 PS1, Line 9: variable MTRRs
What about fixed MTRRs?
Those are undefined as well. But since I keep them disabled I don't bother clearing them.
https://review.coreboot.org/c/coreboot/+/40764/1/src/cpu/x86/mtrr/earlymtrr.... File src/cpu/x86/mtrr/earlymtrr.c:
https://review.coreboot.org/c/coreboot/+/40764/1/src/cpu/x86/mtrr/earlymtrr.... PS1, Line 50: int
unsigned int […]
I kept the same data types as get_free_var_mtrr. get_var_mtrr_count also returns an int. If you think this needs clean up, we can do that in a followup.