Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55354 )
Change subject: device: Add helper function devfn_disable() ......................................................................
Patch Set 1:
(4 comments)
File src/device/device_const.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121219): https://review.coreboot.org/c/coreboot/+/55354/comment/efeea83b_11a140cd PS1, Line 410: struct device *dev = pcidev_path_on_root(devfn); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121219): https://review.coreboot.org/c/coreboot/+/55354/comment/a626f73d_f603b254 PS1, Line 410: struct device *dev = pcidev_path_on_root(devfn); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121219): https://review.coreboot.org/c/coreboot/+/55354/comment/da98abea_7527f536 PS1, Line 411: if (is_dev_enabled(dev)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121219): https://review.coreboot.org/c/coreboot/+/55354/comment/861df121_fc39bc1a PS1, Line 411: if (is_dev_enabled(dev)) please, no spaces at the start of a line