build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39113 )
Change subject: soc/intel/tigerlake: Add Jasper Lake GPIO definitions
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39113/1/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/gpio_soc_defs_jsl.h:
https://review.coreboot.org/c/coreboot/+/39113/1/src/soc/intel/tigerlake/inc...
PS1, Line 25: #define GPP_A 0x2
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39113/1/src/soc/intel/tigerlake/inc...
PS1, Line 34: #define GPP_G 0xB
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ee2601f5761354c3ae24d0fb13f902d0d49496f
Gerrit-Change-Number: 39113
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 25 Feb 2020 08:12:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment