Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35983 )
Change subject: soc/intel/common: Drop Lewis Burg PCIe Root Port IDs
......................................................................
Patch Set 1:
Maxim, I'm not sure why these IDs were added. There doesn't seem
to be general support for this chipset?
Lewisburg PCIe not tested yet
I agree with you that these IDs should not be here.
However, if we want to separate IDs by soc type, then we will need to create a separate directory soc/intel/pch/lewisburg for Lewisburg, since several different processors (Sky/Cascade/Cooper Lake) use this PCH
Please ignore, this was just noise. I thought it could be helpful
to have individual drivers for the root-port renumbering. Turned
out that once the PCI device code picks up the DIDs, it's too late
to patch the devicetree easily.
(I think src/southbridge/intel/ would be a much better place for PCHs)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35983
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5d7de68a962a96f2694f8a6212e3aeba6bebf23
Gerrit-Change-Number: 35983
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 17 Oct 2019 19:33:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment