Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48461 )
Change subject: src: Replace ENV_PCI_SIMPLE_DEVICE with __SIMPLE_DEVICE__ treewide ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Reverts CB:35654 so what's the motivation for the change?
I'm guessing some of the followup changes of removing .c includes breaks without this, did you check for missing <device/pci_ops.h> includes?
Every change is at least build tested, so missing includes shouldn't bean issue here.
My motivation is that ENV_PCI_SIMPLE_DEVICE is an internal symbol in pci_ops.h, so it shouldn't be used anywhere in the source. The appropriate symbol is __SIMPLE_DEVICE__ (as I understand it) which is used treewide.
You can discuss this in CB:35652
It's __SIMPLE_DEVICE__ that should disappear instead. The change is analogous to removals of using __BOOTBLOCK__, __ROMSTAGE__, __ROMCC__ etc.