Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM) ......................................................................
Patch Set 8:
(3 comments)
when similar code went into depthcharge, there was a lot of push-back on querying the EC for data that's effectively static configuration. for example, the number of type-C ports and the underlying USB port mapping is static configuration.
can we extract such information from the device tree?
https://review.coreboot.org/c/coreboot/+/42078/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42078/8//COMMIT_MSG@15 PS8, Line 15: TEST= Tested boots from USB Type-C flash drive and Type-C to Type-A : dongle on Volteer this code isn't used to boot from USB.
https://review.coreboot.org/c/coreboot/+/42078/8/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/8/src/ec/google/chromeec/ec.c... PS8, Line 1381: EC_CMD_CHARGE_PORT_COUNT EC_CMD_USB_PD_PORTS
https://review.coreboot.org/c/coreboot/+/42078/8/src/ec/google/chromeec/ec.c... PS8, Line 1490: reserved we're planning to remove this hack.