Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32123 )
Change subject: Documentation: Add coreboot architecture ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... File Documentation/getting_started/architecture.md:
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 9: , no comma needed here
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 9: seperate separate
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 11: , I guess no comma needed here?
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 13: given a given
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 25: setup set up
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 47: actived activated
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 50: * bootblock : * romstage : * verstage : * postcar Wouldn't it be better to mention the stages here in the order they will be executed?
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 58: starts it starts
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 66: initialized initializes
https://review.coreboot.org/#/c/32123/2/Documentation/getting_started/archit... PS2, Line 83: TPM init It depends on the bootflow. TPM can be initialized in verstage already.