Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35103 )
Change subject: [WIP] mb/intel/cannonlake_rvp,coffeelake_rvp: Add LPC_TPM
......................................................................
Patch Set 4:
Seems to me that MAINBOARD_HAS_LPC_TPM currently is alias of LPC_TPM ?
Can we consider some cleanup here to support cases where TPM is an add-on on LPC connector and not a fixed part of the configuration? We would need to keep chip entry in devicetree.cb for LPC routing purposes at least.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia959ae9072e3fc709b779b1fc778eb82e10c2ee3
Gerrit-Change-Number: 35103
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sachin Agrawal
sachin.agrawal@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Nov 2019 04:00:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment