Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41884/8/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/8/src/drivers/intel/dptf/dptf... PS8, Line 77: acpigen_emit_eisaid("INT3400");
Are we following the DPTF spec or DTT spec. […]
I've been trying to decide whether or not to backport this to older platforms, so that we could completely get rid of all of the DPTF ASL files, but I count 100 'dptf.asl' files in src/mainboard/, so that may not be worthwhile and we should just stick with the new _HID values. If I needed to support both old & new then there would have to be a way to select which set of _HID values to use, but if I'm not backporting, it's easy 😊
However, our current implementation of acpigen_emit_eisaid only supports the 7-character format for EISA IDs. So I need to figure out what iasl is doing with the 8-character ones and add a function for that first... it's on my list of things to do !