Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: mb/bostentech: Add GBYT4 port ......................................................................
Patch Set 25:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43087/25/src/mainboard/bostentech/g... File src/mainboard/bostentech/gbyt4/mainboard.c:
https://review.coreboot.org/c/coreboot/+/43087/25/src/mainboard/bostentech/g... PS25, Line 123: #if CONFIG(VGA_ROM_RUN) I am not sure how to handle the x86emu stuff above without using the preprocessor.
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... File src/mainboard/unk/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... PS1, Line 86:
space
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/gpi... File src/mainboard/unk/gbyt4/gpio.c:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/gpi... PS1, Line 208: struct soc_gpio_config* mainboard_get_gpios(void)
Would be good to fix
Done