Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run DRAM init blob
......................................................................
Patch Set 23:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui...
File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui...
PS14, Line 38: $(CBFS_COMPRESS_FLAG)
I thought this must be raw?
Changed to "none".
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui...
PS14, Line 40: cbfs-files-y += $(DRAM_CBFS)
add one level of indent since it's inside ifndeq
Done
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/14/src/mainboard/google/kukui...
PS14, Line 40:
remove the blank line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad05a77e6353f37cd5ea897203d528762f44176e
Gerrit-Change-Number: 34872
Gerrit-PatchSet: 23
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 23 Sep 2019 02:40:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment