[coreboot-gerrit] [S] Change in coreboot[master]: intel/meteorlake: remove skip_mbp_hob SOC chip config

[Kapil Porwal (Code Review)]

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71997 )

Change subject: intel/meteorlake: remove skip_mbp_hob SOC chip config
......................................................................

intel/meteorlake: remove skip_mbp_hob SOC chip config

Always enable `SkipMbpHob` UPD for MTL FSP.

BUG=none
TEST=TBD. Build and boot to Google/Rex.

Signed-off-by: Kapil Porwal 
Change-Id: Iaba1ea29a92a63d2b287e1ccdea1a81ec07b9971
---
M src/mainboard/google/rex/variants/rex0/overridetree.cb
M src/soc/intel/meteorlake/chip.h
M src/soc/intel/meteorlake/romstage/fsp_params.c
3 files changed, 16 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/71997/1

diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb
index 41da819..f3952a2 100644
--- a/src/mainboard/google/rex/variants/rex0/overridetree.cb
+++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb
@@ -70,8 +70,6 @@
    	[PchSerialIoIndexI2C5] = PchSerialIoPci,
    }"

-	register "skip_mbp_hob" = "1"
-
    # Intel Common SoC Config
    #+-------------------+---------------------------+
    #| Field             |  Value                    |
diff --git a/src/soc/intel/meteorlake/chip.h b/src/soc/intel/meteorlake/chip.h
index 080f057..97b3c5b 100644
--- a/src/soc/intel/meteorlake/chip.h
+++ b/src/soc/intel/meteorlake/chip.h
@@ -352,12 +352,6 @@
     * Set this to 1 in order to disable Package C-state demotion.
     */
    bool disable_package_c_state_demotion;
-
-	/*
-	 * Enable or Disable Skipping MBP HOB.
-	 * Default is set to 0 and set to 1 to skip the MBP HOB.
-	 */
-	bool skip_mbp_hob;
 };

typedef struct soc_intel_meteorlake_config config_t;
diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c
index add927d..f26b417 100644
--- a/src/soc/intel/meteorlake/romstage/fsp_params.c
+++ b/src/soc/intel/meteorlake/romstage/fsp_params.c
@@ -187,7 +187,7 @@
    m_cfg->GpioOverride = 0x1;

/* Skip MBP HOB */
-	m_cfg->SkipMbpHob = config->skip_mbp_hob;
+	m_cfg->SkipMbpHob = 1;
 }

static void fill_fspm_audio_params(FSP_M_CONFIG *m_cfg,