Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33139 )
Change subject: sb/intel/ibexpeak/smihandler: Move finalizing to a common location
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
LGTM, although the log message "APMC: FINALIZE" is removed?
I could add it to sb/intel/common/smihandler.c. OTOH on this platform it makes sense to move locking down out of SMM as no product ever depended on it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8bbb2f65bbe674bd1bc4ae8a4086bd1f5e9a79fa
Gerrit-Change-Number: 33139
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 15 Jun 2019 17:43:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment