20 Dec
2020
20 Dec
'20
5:32 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48771 )
Change subject: mainboard/lenovo: Add Thinkpad Edge S220 (a.k.a E220s) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48771/1/src/mainboard/lenovo/s220/s... File src/mainboard/lenovo/s220/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48771/1/src/mainboard/lenovo/s220/s... PS1, Line 77: printk(BIOS_INFO, "mainboard_smi_apmc(%02x)\n", data); Prefer using '"%s...", __func__' to using 'mainboard_smi_apmc', this function's name, in a string
--
To view, visit https://review.coreboot.org/c/coreboot/+/48771
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I746798b13e83d1971bb7be93751a15875d16c337
Gerrit-Change-Number: 48771
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 20 Dec 2020 17:32:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment