Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31080 )
Change subject: vendorcode/google/chromeos: Add option for using ACPI GPIO pin ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31080/1/src/vendorcode/google/chromeos/acpi.... File src/vendorcode/google/chromeos/acpi.c:
https://review.coreboot.org/#/c/31080/1/src/vendorcode/google/chromeos/acpi.... PS1, Line 18: #if IS_ENABLED(CONFIG_CHROMEOS_ACPI_GPIO_GENERATE_PIN) Would it hurt to always include the header file?
https://review.coreboot.org/#/c/31080/1/src/vendorcode/google/chromeos/acpi.... PS1, Line 34: #if IS_ENABLED(CONFIG_CHROMEOS_ACPI_GPIO_GENERATE_PIN) Any reason to use pre-processor code instead of C?