[coreboot-gerrit] Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )

Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................

Patch Set 76:

(5 comments)

https://review.coreboot.org/c/coreboot/+/32734/74//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/32734/74//COMMIT_MSG@12 
PS74, Line 12: SeaBios
> SeaBIOS, just like in https://www.seabios. […]

Done

https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11ssh/Kconfig:

https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... 
PS74, Line 67: 
             : config SUBSYSTEM_VENDOR_ID
             : 	hex
             : 	default 0x8086
> Is this used anywhere?

Yes, in `soc/intel/skylake/chip_fsp20.c`

https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11ssh/mainboard.c:

PS74:
> I think you can remove this file if it's empty

Done

https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... 
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... 
PS74, Line 114: X550T
> Maybe mention it's the 10GbE device

Done

https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/x... 
PS74, Line 223: 10GBE
> Nit: 10GbE (since it's Gbit, not GByte)

Done