Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38590 )
Change subject: vendorcode/eltan/security: Switch to vb2 vboot library ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38590/2/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/verified_boot/vboot_check.c:
https://review.coreboot.org/c/coreboot/+/38590/2/src/vendorcode/eltan/securi... PS2, Line 17: #define NEED_VB20_INTERNALS /* Peeking into vb2_shared_data */
Is there a timeline from your side?
It's more of a question of when the next situation comes up where we want to change some interface you're using here and it's not trivial to adapt your code to the changes. I can't predict when that happens, could be next week or not for another year. But when it happens we wouldn't want to get stuck and be unable to continue our work because of this.
If you're using this for a current product but are planning to abandon it afterwards, it would probably be best if you could cut off a branch for work on that product (here or on some local mirror of yours) and then delete this code from master.
https://review.coreboot.org/c/coreboot/+/38590/5/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/verified_boot/vboot_check.c:
https://review.coreboot.org/c/coreboot/+/38590/5/src/vendorcode/eltan/securi... PS5, Line 162: vb2_digest_buffer Uhh... you sure this preserves behavior? Because your previous code was byte-swapping this hash (which is odd, btw, I've never seen any other code treat a whole 32-byte hash as "little-endian"), and you're not doing that anymore now.