Attention is currently required from: Jacob Garber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55075 )
Change subject: include: always unsigned long for size_t ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Example build failure:
``` CC verstage/commonlib/bsd/cbfs_mcache.o In file included from src/commonlib/bsd/include/commonlib/bsd/cbfs_private.h:42, from src/commonlib/bsd/cbfs_mcache.c:4: src/commonlib/bsd/cbfs_mcache.c: In function 'cbfs_mcache_build': src/include/cbfs_glue.h:23:36: error: format '%zx' expects argument of type 'size_t', but argument 6 has type 'long unsigned int' [-Werror=format=] #define LOG(...) printk(BIOS_INFO, "CBFS: " __VA_ARGS__) ^~~~~~~~ src/commonlib/bsd/cbfs_mcache.c:86:2: note: in expansion of macro 'LOG' LOG("mcache @%p built for %d files, used %#zx of %#zx bytes\n", mcache, ^~~ src/commonlib/bsd/cbfs_mcache.c:86:54: note: format string is defined here LOG("mcache @%p built for %d files, used %#zx of %#zx bytes\n", mcache, ~~~^ %#lx ```
The length modifier `z` also needs to be redefined?
Do you think it’s a good idea to divert from the use in other projects?