build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32840 )
Change subject: WIP: google/flapjack: Add Panels support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32840/1/src/mainboard/google/kukui/panel_fla... File src/mainboard/google/kukui/panel_flapjack.c:
https://review.coreboot.org/#/c/32840/1/src/mainboard/google/kukui/panel_fla... PS1, Line 1032: if (ABS(value - intf->all_panel_info[id].voltage) < tolerance) line over 80 characters
https://review.coreboot.org/#/c/32840/1/src/mainboard/google/kukui/panel_fla... PS1, Line 1038: return (union panel_id)((sku_id() >> FLAPJACK_PANEL_ID_BIT_POSITION) & 0xf); line over 80 characters