Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: sb/intel/bd82x6x: Support ME Soft Temporary Disable Mode ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37115/19/src/southbridge/intel/bd82... File src/southbridge/intel/bd82x6x/early_me.c:
https://review.coreboot.org/c/coreboot/+/37115/19/src/southbridge/intel/bd82... PS19, Line 94: set_global_reset That can be factored out in a separate commit
https://review.coreboot.org/c/coreboot/+/37115/19/src/southbridge/intel/bd82... File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/37115/19/src/southbridge/intel/bd82... PS19, Line 764: me_state_prev What happens on CMOS reset? me_state_prev will be state_normal and thus the ME won't come out of soft disable.
https://review.coreboot.org/c/coreboot/+/37115/19/src/southbridge/intel/bd82... File src/southbridge/intel/bd82x6x/me_common.c:
https://review.coreboot.org/c/coreboot/+/37115/19/src/southbridge/intel/bd82... PS19, Line 3: arch Seems unused