Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35519 )
Change subject: device/cardbus: Remove unnecessary bridge_ctrl bitmask ......................................................................
device/cardbus: Remove unnecessary bridge_ctrl bitmask
The bits PARITY and SERR are set unconditionally below.
Change-Id: I03f53fe7f436f8feed7b34756439077f02a85565 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35519 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Michael Niewöhner --- M src/device/cardbus_device.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index 826d785..48c54bc 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -152,8 +152,6 @@
ctrl = pci_read_config16(dev, PCI_CB_BRIDGE_CONTROL); ctrl |= (dev->link_list->bridge_ctrl & ( - PCI_BRIDGE_CTL_PARITY | - PCI_BRIDGE_CTL_SERR | PCI_BRIDGE_CTL_NO_ISA | PCI_BRIDGE_CTL_VGA | PCI_BRIDGE_CTL_MASTER_ABORT |