EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38526 )
Change subject: ec/google/wilco: add ec command set cpu id ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38526/1/src/ec/google/wilco/command... File src/ec/google/wilco/commands.h:
https://review.coreboot.org/c/coreboot/+/38526/1/src/ec/google/wilco/command... PS1, Line 354: int wilco_ec_set_cpuid(uint32_t cpuid, uint8_t cpu_cores,uint8_t gpu_cores);
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/38526/1/src/ec/google/wilco/command... File src/ec/google/wilco/commands.c:
https://review.coreboot.org/c/coreboot/+/38526/1/src/ec/google/wilco/command... PS1, Line 238: int wilco_ec_set_cpuid(uint32_t cpuid, uint8_t cpu_cores,uint8_t gpu_cores)
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/38526/1/src/ec/google/wilco/command... PS1, Line 250: ARRAY_SIZE(cpu_id),NULL, 0);
space required after that ',' (ctx:VxV)
Done