Roger Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: mediatek/mt8192: add spmfw loader
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp...
File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/46389/15/src/soc/mediatek/mt8192/sp...
PS15, Line 947: write32(&mtk_spm->pcm_con1, read32(&mtk_spm->pcm_con1) |
: SPM_REGWR_CFG_KEY | RG_IM_SLAVE_LSB);
2=> Oh, it is hardware detail design. Need to consult with SPM designer.
Replied by SPM Designer:
There is a define file for SPM core to identify which part of SPM SRAM is used as Program Memory or Data Memory. After the DMA completed moving code to SPM SRAM, SPM core reset will be released and start to run code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6478b98f426d2f3e0ee919d37d21d909ae8a6371
Gerrit-Change-Number: 46389
Gerrit-PatchSet: 16
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Nicolas Boichat
drinkcat@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 05 Nov 2020 07:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Nicolas Boichat
drinkcat@chromium.org
Gerrit-MessageType: comment