Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Split i2c implementation for psp_verstage ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... File src/soc/amd/picasso/i2c-x86.c:
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... PS5, Line 11: i2c_bus_address[]
i2c_bus_address[I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT]
Fixing in follow-on patch.
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... PS5, Line 19: _Static_assert( : ARRAY_SIZE(i2c_bus_address) == I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT, : "ARRAY_SIZE(i2c_bus_address) must equal I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT");
remove
fixing in follow-on patch
https://review.coreboot.org/c/coreboot/+/42064/2/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/2/src/soc/amd/picasso/i2c.c@1... PS2, Line 140: gpio_ptr = gpio_get_address(gpio);
gpio_get_address() returns one of ACPIMMIO_GPIOx_BASE and is only valid for x86. […]
Done
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c.c@1... PS5, Line 169: cfg = config_of_soc();
Unrelated. This currently brings in the entire static devicetree / static. […]
Done