Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39519 )
Change subject: util/inteltool: add code for dumping SMBus registers
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
looks good to me; haven't checked the register offsets and names though
https://review.coreboot.org/c/coreboot/+/39519/12/util/inteltool/smbus.c
File util/inteltool/smbus.c:
https://review.coreboot.org/c/coreboot/+/39519/12/util/inteltool/smbus.c@86
PS12, Line 86: size_t i, registers_size = 0, cfg_registers_size = 0, tco_registers_size = 0;
one line per 0-initialized variable?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73f1e1544ceccfa538bb9b0a8c21e10fc42bedb6
Gerrit-Change-Number: 39519
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 20 Mar 2020 20:52:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment