Attention is currently required from: KunYi Chen.
Nicholas Chin has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 4:
(8 comments)
File src/mainboard/lattepanda/mu/Kconfig:
https://review.coreboot.org/c/coreboot/+/83719/comment/7113407b_4a71d0c3?usp... : PS4, Line 7: select BOARD_ROMSIZE_KB_16384 : select DRIVERS_INTEL_DPTF : select DRIVERS_UART_8250IO : select FSP_TYPE_IOT : select DRIVERS_SPI_ACPI : select DRIVERS_USB_ACPI : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select HAVE_SPD_IN_CBFS : select INTEL_GMA_HAVE_VBT : select SOC_INTEL_ALDERLAKE_PCH_N : select SUPERIO_ITE_IT8613E Nit: Sort alphabetically
https://review.coreboot.org/c/coreboot/+/83719/comment/8a1d943f_aa7bb0dd?usp... : PS4, Line 27: int Type not necessary as it's already defined in `console/Kconfig`
File src/mainboard/lattepanda/mu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/38f32d85_9deb25d8?usp... : PS4, Line 1: Remove empty line 1
https://review.coreboot.org/c/coreboot/+/83719/comment/5e7b4154_c1c985a1?usp... : PS4, Line 18: void bootblock_mainboard_init(void) : { : } Can be removed if not used, as there is a weak implementation defined in `lib/bootblock.c`
File src/mainboard/lattepanda/mu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83719/comment/03cbc9e0_842f6cb3?usp... : PS4, Line 1: Remove empty line 1
https://review.coreboot.org/c/coreboot/+/83719/comment/15562de7_bcd0ff0f?usp... : PS4, Line 242: device ref ipu off end Already set to off in chipset devicetree, can be removed.
https://review.coreboot.org/c/coreboot/+/83719/comment/3e86f90c_ff57aaad?usp... : PS4, Line 251: device ref heci1 on end Already set to on in chipset devicetree, can be removed.
https://review.coreboot.org/c/coreboot/+/83719/comment/4b3cf8e3_b4984648?usp... : PS4, Line 252: device ref sata off end : device ref i2c5 off end Same as chipset devicetree, remove