Attention is currently required from: Hung-Te Lin, Xin Ji, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Xin Ji. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email )
Change subject: mb/google/corsola: fine tune the data lane trail ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86101/comment/3be2de75_d9adccf2?usp... : PS1, Line 7: fine tune the data lane trail More specific:
Increase ANX7625 data trail time
https://review.coreboot.org/c/coreboot/+/86101/comment/7e686e82_486ef55b?usp... : PS1, Line 8: Please start by describing the problem, like: Currently, the display flickers.
https://review.coreboot.org/c/coreboot/+/86101/comment/02eaa915_b4368dd0?usp... : PS1, Line 9: ANX7625 requires customized hs_da_trail time Why? According to the schematics?
https://review.coreboot.org/c/coreboot/+/86101/comment/02aea16e_583bcfe7?usp... : PS1, Line 9: override the : data trail for ANX7625 What is the current value, and what is the new value? Why is the new value correct?
File src/mainboard/google/corsola/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/86101/comment/01d466a0_c0cba690?usp... : PS1, Line 69: timing->da_hs_trail += 9; Maybe better use the absolute value, or does it always need to be increased by nine?