[coreboot-gerrit] [M] Change in coreboot[main]: mb/emulation/qemu-riscv: Change to -bios option

[Philipp Hug (Code Review)]

Attention is currently required from: Arthur Heymans, Maximilian Brune, ron minnich.

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80746?usp=email )

Change subject: mb/emulation/qemu-riscv: Change to -bios option
......................................................................

Patch Set 6: Code-Review+1

(4 comments)

File src/mainboard/emulation/qemu-riscv/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/80746/comment/20f138ae_192cce05 :
PS6, Line 7: bootblock-y += cbmem.c
no need to move them to bootblock-y, those can stay romstage-y, to allow both with and without separate romstage

File src/mainboard/emulation/qemu-riscv/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/80746/comment/72eef9a5_de0e0460 :
PS6, Line 20: #if ENV_SEPARATE_ROMSTAGE
romstage can be placed at same place as opensbi to keep separate romstage support

File src/mainboard/emulation/qemu-riscv/romstage.c:

https://review.coreboot.org/c/coreboot/+/80746/comment/1b130a27_319c897c :
PS6, Line 9: 	console_init();
add main to allow both with and without separate romstage:
#if CONFIG(SEPARATE_ROMSTAGE)
void main(void)
{
    console_init();
    romstage_main();
}
#endif

File util/qemu/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/80746/comment/26f55ef6_b620546f :
PS6, Line 32: QEMU-$(CONFIG_BOARD_EMULATION_QEMU_RISCV_RV64)	?= qemu-system-riscv64 -M virt -drive \
maybe add -m 1G as well here, as the default memory size is really low on riscv