Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37559 )
Change subject: vendorcode/intel/fsp: Add Jasperlake FSP headers for FSP v1433
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37559/6/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/jasperlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/37559/6/src/vendorcode/intel/fsp/fs...
PS6, Line 25: ///
coreboot guide line '/*' for comment
This is directly taken from FSP release.
the format is same as https://github.com/IntelFsp/FSP/blob/master/IceLakeFspBinPkg/Include/Firmwar...
the FSPx header also are auto generated for a given FSP build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacb44204c3f7220a20ab3edc2163c97188014bbf
Gerrit-Change-Number: 37559
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 11:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment