[coreboot-gerrit] Change in ...coreboot[master]: soc/amd: Update ACPI code

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 )

Change subject: soc/amd: Update ACPI code
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2:
>
> (1 comment)
>
> I think you should separate your OS stuff into a separate stack.  Keep the additional cores change for the merlinfalcon work.

This is for merlinfalcon, as the same ASL is used both for stoneyridge and merlinfalcon.

https://review.coreboot.org/#/c/33620/2/src/soc/amd/common/acpi/lpc.asl 
File src/soc/amd/common/acpi/lpc.asl:

https://review.coreboot.org/#/c/33620/2/src/soc/amd/common/acpi/lpc.asl@35 
PS2, Line 35: PNP0C02 apparently fails with WIN7 and WIN10. Until better
            : 	 * understood,
> I'm not sure why "apparently" here.  Either it fails or it doesn't. […]

I'll do some test later to confirm or reject my suspicion. Then I'll change this comment based on what I find.