Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47980 )
Change subject: lp4x: Add new memory parts and generate SPDs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_...
File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_...
PS1, Line 221: {
looks like you have a mix of tabs and spaces for indentation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09c6eab640c169dbdb451964967d14a31e314496
Gerrit-Change-Number: 47980
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 22:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment