Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36292 )
Change subject: soc/amd: Use common functions to pass UMA information to ramstage
......................................................................
Patch Set 2:
(1 comment)
Still -1 as biosram is required for cbmem_top(), UMA base/size change is probably fine.
https://review.coreboot.org/c/coreboot/+/36292/2/src/soc/amd/common/block/pi...
File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/c/coreboot/+/36292/2/src/soc/amd/common/block/pi...
PS2, Line 209: PostParams->MemConfig.UmaSize * 64 * KiB);
Ah... I did not review preceding work and did not realise this does not depend of cbmem_initialize() having being called.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36292
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a14044a93d1188cacc488006abe50a112d0eb8
Gerrit-Change-Number: 36292
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Oct 2019 07:11:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment