HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45451 )
Change subject: nb/intel/gm45: Introduce memmap.h ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/... PS3, Line 173: #define DEFAULT_MCHBAR 0xfed14000 : #define DEFAULT_DMIBAR 0xfed18000 : #define DEFAULT_EPBAR 0xfed19000
please see https://review.coreboot.org/c/coreboot/+/45610/17 […]
You have every right to opt out of my reviews,
but removing your self from CB: 31196 CB: 46282 CB: 46283 CB: 45574 CB: 46279 CB: 45781 CB: 46122 after I politely asked you not to make any changes here because of CB:45610, it's childish ...
so let move current comment go to resolved status (even though I didn't give any score) and avoid possible drama.